Document server version, variant, & constant changes #149
Conversation
TheRealPear
force-pushed
the
cond-constants
branch
from
5fd5cae
to
0f08d0d
Compare
docs/modules/general/main.mdx
Outdated
| | `min-server-version` | The minimum server version this variant can run on.<br />**Note:** PGM will attempt to detect the map version from its `level.dat` file. | | ||
| | `max-server-version` | The maximum server version this variant can run on. | |
There was a problem hiding this comment.
referencing variants in if min-server-version makes little sense
also the note here makes no sense
There was a problem hiding this comment.
referencing variants in
ifmin-server-version makes little sense
These also show up in Map attributes table as well. Are there no map variants that would be using a different version than the original map?
There was a problem hiding this comment.
The thing is simply that if is deciding if this block of xml applies or not based on the version. Variant is irrelevant
<if min-server-version="1.9">
<item>shield</item>
</if>this is purely a version dependant line of xml, that has NO relation to variants whatsoever. The map can play in 1.8 and shields won't be referenced, or if it plays in 1.9+ then shields are mentioned (imagine this being an itemremove or whatever)
TheRealPear
force-pushed
the
cond-constants
branch
from
0f08d0d
to
acf8047
Compare
Signed-off-by: Pear <[email protected]>
TheRealPear
force-pushed
the
cond-constants
branch
from
acf8047
to
92360fa
Compare
min-server-versionandmax-server-versionfor both map element and variants, resolves Document server-version limits in map & variants #133 and resolves Document min/max server version conditionals #129.fallbackattribute for constants, resolves Fallback attribute on constants #130.